Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] JDK 17 support #2898

Closed
clemstoquart opened this issue Jul 8, 2021 · 5 comments · Fixed by #2936
Closed

[FEATURE] JDK 17 support #2898

clemstoquart opened this issue Jul 8, 2021 · 5 comments · Fixed by #2936
Assignees
Milestone

Comments

@clemstoquart
Copy link

Hello lombok team,

JDK 17 release is just around the corner and it would be very convenient to have at least a lombok snapshot to start working on the migration.

Thanks !

@Rawi01
Copy link
Collaborator

Rawi01 commented Jul 9, 2021

Thanks for the reminder, release date for Java 17 is 2021-09-14.

So far I have identified these tasks:

  • Support new switch expressions
  • Support sealed classes
  • Update ASM to 9.1+

I already started to fix the first switch expression related thing (https://github.com/Rawi01/lombok/tree/jdk-17).

@rzwitserloot
Copy link
Collaborator

An edge release is out with this patch applied. Give it a whirl if you like :)

https://projectlombok.org/download-edge

@rzwitserloot rzwitserloot added this to the next-version milestone Sep 16, 2021
@chrisgleissner
Copy link

chrisgleissner commented Sep 16, 2021

The edge release works well on a large project that uses most of Lombok's features. We had trouble with the @Singular annotation and slow val performance. Both are fixed as I verified on OpenJDK 11 and 17GA. We are keen to upgrade and hope that a new release can be cut soon.

@clemstoquart
Copy link
Author

Hi,
I confirm that everything is now working fine with JDK 17 🎉

@rzwitserloot
Copy link
Collaborator

Weeeellll, time for us to start getting a new release out the door Real Soon Now. @Rawi01 deserves all the credit for making it work. @clemstoquart gracias for checking the edge build!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants