Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Bump AWS Kinesis client version #26295

Closed
2 of 15 tasks
psolomin opened this issue Apr 17, 2023 · 4 comments
Closed
2 of 15 tasks

[Task]: Bump AWS Kinesis client version #26295

psolomin opened this issue Apr 17, 2023 · 4 comments

Comments

@psolomin
Copy link
Contributor

What needs to happen?

Current Kinesis client lib version is 2.3.4 which is > 2 years old, so it needs a bump.

implementation "software.amazon.kinesis:amazon-kinesis-client:2.3.4", excludeNetty

It brings Lombok dependency which is not compatible with Java 17 (projectlombok/lombok#2898)

$ ./gradlew -p sdks/java/io/amazon-web-services2 -q dependencies --configuration testRuntimeClasspath
...
+--- software.amazon.kinesis:amazon-kinesis-client:2.3.4
...
|    +--- software.amazon.glue:schema-registry-serde:1.0.0
...
|    |    +--- org.projectlombok:lombok:1.18.2
|    |    \--- org.projectlombok:lombok-utils:1.18.12
|    +--- software.amazon.glue:schema-registry-common:1.0.0 (*)
...

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@aromanenko-dev
Copy link
Contributor

CC: @mosche

@mosche
Copy link
Member

mosche commented Apr 17, 2023

@psolomin Are you planning to look into this? Shall I assign this to you?

@psolomin
Copy link
Contributor Author

@mosche I'm not sure I have time next 2 weeks, I would leave it unassigned for now. Add good first issue maybe? If it stays unassigned by the end of Apr, I will assign myself.

@mosche
Copy link
Member

mosche commented Apr 18, 2023

I had a quick look, actually there's a few issues with transitive dependencies that require a bit of care. Will tackle the next days.

@mosche mosche self-assigned this Apr 18, 2023
mosche pushed a commit to mosche/beam that referenced this issue Apr 21, 2023
@mosche mosche closed this as completed in 581c3dc Apr 21, 2023
@github-actions github-actions bot added this to the 2.48.0 Release milestone Apr 21, 2023
jakubrauch pushed a commit to jakubrauch/beam that referenced this issue Apr 27, 2023
bullet03 pushed a commit to akvelon/beam that referenced this issue Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants