Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Lombok version to support Java 17 #2034

Closed
iluwatar opened this issue Sep 28, 2022 · 2 comments
Closed

Upgrade Lombok version to support Java 17 #2034

iluwatar opened this issue Sep 28, 2022 · 2 comments
Assignees
@karshil2309
Labels
epic: build issue epic: dependencies info: good first issue type: feature
Milestone
1.26.0

Comments

@iluwatar
Copy link
Owner

iluwatar commented Sep 28, 2022 •
edited

This issue is a part of the Java 17 transition plan at https://github.com/iluwatar/java-design-patterns/wiki/19.-Java-17-transition.

According to projectlombok/lombok#2898, Lombok supports Java 17 since version 1.18.22. Our version is a bit behind that, so let's upgrade to the latest.

Acceptance criteria

  • Lombok version has been updated to the latest available
@iluwatar iluwatar mentioned this issue Sep 28, 2022
Open
@karshil2309
Copy link
Contributor

@iluwatar : I will update those hotfixes for java 17. Will create separate branch and create pr for the same.

karshil2309 added a commit to karshil2309/java-design-patterns that referenced this issue Sep 30, 2022
@karshil2309
Updated Lombok version to 1.18.22
df8dbdd 
Ticket issue : iluwatar#2034
@karshil2309 karshil2309 mentioned this issue Sep 30, 2022
Merged
@iluwatar
Copy link
Owner Author

iluwatar commented Oct 3, 2022

Ok @karshil2309

iluwatar pushed a commit that referenced this issue Oct 4, 2022
@karshil2309
dependencies: Updated Lombok version to 1.18.22 (#2038)
57fe447 
Ticket issue : #2034
@iluwatar iluwatar added this to the 1.26.0 milestone Oct 4, 2022
@iluwatar iluwatar closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karshil2309 karshil2309

Labels
epic: build issue epic: dependencies info: good first issue type: feature
Projects
None yet
Milestone
1.26.0
Development

No branches or pull requests
2 participants
@iluwatar @karshil2309