Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fixes TXT resolution by combining broken-up TXT records #181

Merged
merged 3 commits into from May 2, 2024
Merged

This fixes TXT resolution by combining broken-up TXT records #181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d54d6db
This fixes TXT resolution by combining broken TXT records
tekkamanendless Dec 20, 2023
61f0824
Add notes about the RFC
tekkamanendless Dec 20, 2023
acc8565
Revert these changes due to the Go version number changing
tekkamanendless Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions client.go
View file
Open in desktop
Expand Up @@ -656,9 +656,9 @@ func (d *DNSData) ParseFromRR(rrs []dns.RR) error {
case *dns.CAA:
d.CAA = append(d.CAA, trimChars(recordType.Value))
case *dns.TXT:
for _, txt := range recordType.Txt {
d.TXT = append(d.TXT, trimChars(txt))
}
// Per RFC 7208, a single TXT record can be broken up into multiple parts and "MUST be treated as if those strings are concatenated
// together without adding spaces"; see: https://www.rfc-editor.org/rfc/rfc7208
d.TXT = append(d.TXT, strings.Join(recordType.Txt, ""))
case *dns.SRV:
d.SRV = append(d.SRV, trimChars(recordType.Target))
case *dns.AAAA:
Expand Down