This fixes TXT resolution by combining broken-up TXT records #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per RFC 7208, a single TXT record can be broken up into multiple parts and "MUST be treated as if those strings are concatenated together without adding spaces"; see: https://www.rfc-editor.org/rfc/rfc7208 Previously, the client would treat individual TXT sub-record as a full TXT record. This fixes that issue. In doing this, this makes SPF, DMARC, and DKIM queries work as intended.
Mzack9999
added
the
Type: Enhancement
Mzack9999
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 7208, a single TXT record can be broken up into multiple parts and "MUST be treated as if those strings are concatenated together without adding spaces".
Previously, the client would treat individual TXT sub-record as a full TXT record. This fixes that issue.
In doing this, this makes SPF, DMARC, and DKIM queries work as intended.