-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade styled-components to v5 #3397
Merged
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
47419e6
upgrade styled-components to v5
mperrotti ad0d8f5
adds changeset
mperrotti b1c721d
fixes type errors
mperrotti cc7292c
Merge branch 'main' of github.com:primer/react into mp/styled-compone…
mperrotti b092ca8
Update .changeset/proud-rules-develop.md
mperrotti b7ea05d
Merge branch 'main' into mp/styled-components-v5-upgrade
mperrotti 85e593d
Merge branch 'main' into mp/styled-components-v5-upgrade
mperrotti 418d98f
Merge branch 'main' of github.com:primer/react into mp/styled-compone…
mperrotti 8b1dba7
Merge branch 'mp/styled-components-v5-upgrade' of github.com:primer/r…
mperrotti 43e9cdc
updates changeset
mperrotti 89a1739
Merge branch 'main' into mp/styled-components-v5-upgrade
mperrotti 685a430
Merge branch 'main' of github.com:primer/react into mp/styled-compone…
mperrotti 3504e7b
rm Box snapshots emitting empty mq blocks, updates snaps post-merge
mperrotti 70fa296
Merge branch 'mp/styled-components-v5-upgrade' of github.com:primer/r…
mperrotti 6f6d259
Merge branch 'main' of github.com:primer/react into mp/styled-compone…
mperrotti cfcf638
Merge branch 'main' of github.com:primer/react into mp/styled-compone…
mperrotti c0dac98
Merge branch 'main' into mp/styled-components-v5-upgrade
mperrotti File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@primer/react': major | ||
--- | ||
|
||
Upgrades styled-components to v5 | ||
|
||
<!-- Changed components: _none_ --> | ||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very fussy about this because it is a major release but I wonder if the practise should be listing all components that are impacted by this change? 🤔