Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade styled-components to v5 #3397

Merged
merged 17 commits into from Jul 26, 2023
Merged

Upgrade styled-components to v5 #3397

merged 17 commits into from Jul 26, 2023

Conversation

mperrotti
Copy link
Contributor

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023 •
edited

🦋 Changeset detected

Latest commit: c0dac98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mperrotti
mperrotti commented Jun 9, 2023
View reviewed changes
src/__tests__/__snapshots__/Box.test.tsx.snap Outdated
Comment on lines 52 to 62
@media screen and (min-width:544px) {

}

@media screen and (min-width:768px) {

}

@media screen and (min-width:1012px) {

}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's causing these to get output

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is a know issue both for us and for the community

That said since we are moving away from jest snapshots (ADR reference), if this is only snapshot issue (seems like it) we might maybe want to start deleting these snapshots? At least we can start with Box maybe? And if needed we can create a test in Playwright. What do you think?

@mperrotti mperrotti temporarily deployed to github-pages June 9, 2023 15:34 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3397 June 9, 2023 15:35 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023 •
edited

size-limit report 📦

Path Size
dist/browser.esm.js 102.48 KB (0%)
dist/browser.umd.js 103.08 KB (0%)

@mperrotti mperrotti temporarily deployed to github-pages June 9, 2023 16:27 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3397 June 9, 2023 16:27 Inactive
joshblack
joshblack reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🥳 What would the best next steps for this be? Would it be going through and doing a visual inspection to make sure nothing was impacted?

.changeset/proud-rules-develop.md Outdated Show resolved Hide resolved
@mperrotti mperrotti temporarily deployed to github-pages July 7, 2023 15:45 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3397 July 7, 2023 15:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3397 July 7, 2023 15:46 Inactive
@mperrotti
Copy link
Contributor Author

@joshblack - I already went through a bunch of stuff in Storybook, but maybe we could visually review in dotcom

@mperrotti mperrotti temporarily deployed to github-pages July 11, 2023 14:48 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3397 July 11, 2023 14:48 Inactive
@mperrotti mperrotti marked this pull request as ready for review July 11, 2023 23:09
@mperrotti mperrotti requested review from a team and broccolinisoup July 11, 2023 23:09
@mperrotti mperrotti temporarily deployed to github-pages July 11, 2023 23:14 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3397 July 11, 2023 23:15 Inactive
@mperrotti mperrotti temporarily deployed to github-pages July 12, 2023 20:43 — with GitHub Actions Inactive
@mperrotti
Copy link
Contributor Author

if this is only snapshot issue (seems like it) we might maybe want to start deleting these snapshots? At least we can start with Box maybe? And if needed we can create a test in Playwright. What do you think?

@broccolinisoup - I think we can just delete that snapshot

@mperrotti mperrotti temporarily deployed to github-pages July 19, 2023 16:02 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3397 July 19, 2023 16:02 Inactive
joshblack
joshblack approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@mperrotti mperrotti temporarily deployed to github-pages July 20, 2023 13:35 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3397 July 20, 2023 13:35 Inactive
@broccolinisoup
Copy link
Member

if this is only snapshot issue (seems like it) we might maybe want to start deleting these snapshots? At least we can start with Box maybe? And if needed we can create a test in Playwright. What do you think?

@broccolinisoup - I think we can just delete that snapshot

I think so too!

broccolinisoup
broccolinisoup approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@mperrotti mperrotti temporarily deployed to github-pages July 25, 2023 17:35 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3397 July 25, 2023 17:35 Inactive
@mperrotti mperrotti enabled auto-merge July 26, 2023 23:15
@mperrotti mperrotti added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 397938d Jul 26, 2023
31 checks passed
@mperrotti mperrotti deleted the mp/styled-components-v5-upgrade branch July 26, 2023 23:39
@primer-css primer-css mentioned this pull request Jul 26, 2023
Merged
joshblack added a commit that referenced this pull request Jul 27, 2023
@joshblack
Revert "Upgrade styled-components to v5 (#3397)"
452d96b 
This reverts commit 397938d.
@joshblack joshblack mentioned this pull request Jul 27, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 27, 2023
@joshblack
Revert "Upgrade styled-components to v5 (#3397)" (#3567)
d8bbbb3 
This reverts commit 397938d.
@joshblack joshblack mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mperrotti @broccolinisoup @joshblack