Moved pre-commit support to github.com/pre-commit/mirrors-prettier #8937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make current hook fail, * Updated docs to reflect the change. Closes prettier#8925
|
Hi @fisker, here is the PR we were discussing in #8925 (comment) . Regarding the CHANGELOG:
I guess this change is user facing, but I am not sure it feats in one of the given folders. Any suggestion if and where I should mention it ? |
FloChehab
changed the title
|
Also, I am marking this PR as "do not merge" while prettier/pre-commit#1 is not closed. |
|
Maybe |
|
Done ✔️ |
fisker
changed the title
fisker
approved these changes
Oct 21, 2020
thorn0
approved these changes
Oct 21, 2020
This was referenced Oct 28, 2020
This was referenced Nov 1, 2020
|
Just wanted to say thanks for moving this PR forward, if you need something from me, feel free to ask. |
|
One note to @sosukesuzuki , after release, the docs change will not effect stable version, so we need update |
fisker
changed the title
|
pre-commit have setup a repo to support it Changelog will add in #9589 |
mcdonnnj
added a commit
to cisagov/skeleton-generic
that referenced
this pull request
Dec 16, 2020
Per prettier/prettier#8937 the pre-commit hook has been moved to https://github.com/pre-commit/mirrors-prettier. I have also updated to the latest version in that repository.
felddy
added a commit
to felddy/foundryvtt-docker
that referenced
this pull request
Jan 7, 2021
* Insist that the cisagov devs are the owners of the .github directory This additional clause must remain at the _end_ of the CODEOWNERS file so that it cannot be overridden by a later clause. We want to make it so that all the .github files including CODEOWNERS are protected so only code owners (the dev team) can approve modifications to them. This will prevent configuration changes from breaking Actions and other management-type functions that the files in this directory control. By setting the .github files/folder to require code owner approval for changes, workflow and management changes will require dev team review and checking. Resolves #56. * Remove offending slash Thanks to @dav3r and @mcdonnnj for the suggestion. * Use the python version output by actions/setup-python There is no need to run python code to determine the python version. Resolves #58. See here for details: https://github.com/actions/setup-python/blob/main/action.yml#L14-L16 * Organize pre-commit hooks Group related pre-commit hooks together. Make sure that hooks are alphabetically sorted within those groups. * Fix test job missing Python version in cache key * Clean up our actions/cache step Removed name because it was not more informative than the default. Swapped out a hardcoded job reference for the github.job context value. Switch the base cache key to a step environment value so we can set it once and reuse. Removed additional restore-key value that might have undesirable results. * Update remaining actions/cache uses Make sure all actions/cache steps are in-line with the changes made to the lint job's step. * Update prettier hook details Per prettier/prettier#8937 the pre-commit hook has been moved to https://github.com/pre-commit/mirrors-prettier. I have also updated to the latest version in that repository. * Update black hook repo url At some point the python GitHub organization renamed to psf (Python Software Foundation). Although it redirects with no issue, I think it should be updated to reflect the current repository URL. * Remove trailing '.git's from repository URLs Two hooks had trailing '.git's in the URLs. Although this is not a problem, we should be consistent in how we format things. * Enable two additional hooks from default pre-commit-hooks Enabled 'check-case-conflict' because of our mixed Linux and macOS development. Although APFS supports case-sensitive containers, it is not the default as far as I am aware. Linux filesystems are typically case-sensitive however. With the merge of cisagov/development-guide#42 we now have a TOML file in a repository, so it does not hurt to add this hook in case more are added in the future. * Run pre-commit autoupdate * Update repo URL for the isort hook I missed that this repository was transfered from the creator, Timothy Crosley, to the PyCQA organization. * Update ansible-lint hook URL * Run pre-commit autoupdate * Add the pre-commit-packer repo and hooks * Add the --strict flag to the yamllint pre-commot hook The --strict flag will cause the yamllint hook to exit with a non-zero exit code when warnings are found instead of only when errors are found. Co-authored-by: Jeremy Frasier <jeremy.frasier@trio.dhs.gov> Co-authored-by: Nicholas McDonnell <50747025+mcdonnnj@users.noreply.github.com> Co-authored-by: felddy <felddy@github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to discussions in: #8925
Closes #8925
Fixes #9459
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨