Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier hook to new pre-commit repo #639

Merged
merged 2 commits into from Oct 31, 2020

Conversation

paw-lu
Copy link
Contributor

@paw-lu paw-lu commented Oct 28, 2020

Prettier has moved its pre-commit support to github.com/prettier/pre-commit.

Drafting this PR to also test if it will fix the failing actions on Windows.

Closes #640

@paw-lu
Copy link
Contributor Author

paw-lu commented Oct 28, 2020

Looks like this fixed the pre-commit issue on Test / Python 3.9 (windows-latest).

Tests / Python 3.7 (ubuntu-latest) failed for unrelated reasons (ConnectionResetError for Mypy during install step)

@paw-lu paw-lu marked this pull request as ready for review October 28, 2020 05:18
@cjolowicz cjolowicz added this to the 2020.11.15 milestone Oct 31, 2020
@cjolowicz cjolowicz added the bug Something isn't working label Oct 31, 2020
@cjolowicz cjolowicz merged commit fa6c6ae into cjolowicz:master Oct 31, 2020
@cjolowicz
Copy link
Owner

Thank you!

@paw-lu paw-lu deleted the prettier branch November 2, 2020 20:01
@cjolowicz cjolowicz mentioned this pull request Nov 14, 2020
paw-lu added a commit to paw-lu/cookiecutter-hypermodern-python that referenced this pull request Mar 8, 2021
* Change to new prettier pre-commit repo

* Add v prefix to prettier rev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Prettier pre-commit hook to new repo
2 participants