Update ignore to v5
#6975
Closed
Update ignore to v5
#6975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
Nov 16, 2019
fisker
force-pushed
the
update-ignore
branch
from
9522318
to
24879bd
Compare
lydell
reviewed
Nov 16, 2019
fisker
commented
Nov 16, 2019
fisker
commented
Nov 16, 2019
lydell
reviewed
Nov 17, 2019
src/cli/util.js
Outdated
| try { | ||
| fileIgnored = ignorer.ignores(path.relative(process.cwd(), filename)); | ||
| } catch (_) { | ||
| // Invalid path |
There was a problem hiding this comment.
Would it be better to do this update in next instead and show this error to the user? I’m not sure what an “invalid path” is, but it sounds useful to get to know that some of my patterns are wrong?
There was a problem hiding this comment.
I don't know. I'm not changing current behave
There was a problem hiding this comment.
@evilebottnawi Do you have experience from ESLint or stylelint?
…nore # Conflicts: # yarn.lock
lydell
reviewed
Nov 18, 2019
Co-Authored-By: Simon Lydell <simon.lydell@gmail.com>
lipis
approved these changes
Nov 23, 2019
| try { | ||
| fileIgnored = ignorer.ignores(path.relative(process.cwd(), filename)); | ||
| } catch (_) { | ||
| // Invalid path. TODO: Should we show this error to the user, rather than swallowing it? |
There was a problem hiding this comment.
Maybe we should add note for next major release about that?
|
/cc @fisker what is status? |
|
Not sure what I can do |
|
After reading sindresorhus/globby#120 , sindresorhus/globby#112 and sindresorhus/globby#104 I think I did something wrong |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨