-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ignore
to v5
#8546
Update ignore
to v5
#8546
Conversation
…nore # Conflicts: # yarn.lock
Co-Authored-By: Simon Lydell <simon.lydell@gmail.com>
# Conflicts: # package.json # src/cli/util.js # src/common/get-file-info.js
# Conflicts: # src/common/get-file-info.js # yarn.lock
# Conflicts: # src/common/get-file-info.js
I'd like to take a deeper look at this PR, but I need time for that. Please don't merge for now. |
# Conflicts: # package.json
# Conflicts: # src/cli/util.js # src/common/get-file-info.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review?
It's ready long time ago, just solved the conflicts, still waiting for @thorn0 review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
Here's what bothers me about this change. ./foo/ignore.txt
./bar.js
prettier --ignore-path foo/ignore.txt . Result with Prettier 2.0.5: So this change is breaking. |
FYI, the related file path pass to |
I understand why it works this way, but this is still a breaking change. |
If the breaking change is what you worried about, we can merge later. Most important is, which behavior do you prefer? I think the new one not bad. |
The new behavior is aligned with Git. It looks simpler and cleaner to me, especially if support for multiple ignore files is going to be added. But as long as Prettier doesn't have that support and because we don't know how and why people usually use In order to both keep the behavior and update |
# Conflicts: # package.json # src/cli/util.js # src/common/get-file-info.js # tests_integration/__tests__/__snapshots__/file-info.js.snap # tests_integration/__tests__/file-info.js # tests_integration/__tests__/ignore-emoji.js # yarn.lock
Use |
Previous attempt #6975
docs/
directory)changelog_unreleased/*/pr-XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨