Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19 blog post #6486

Closed
wants to merge 17 commits into from
Closed

1.19 blog post #6486

wants to merge 17 commits into from

Conversation

duailibe
Copy link
Member

@duailibe duailibe commented Sep 16, 2019

ETA: 9/25

@duailibe duailibe mentioned this pull request Sep 16, 2019
@lydell
Copy link
Member

lydell commented Sep 16, 2019

Looks like we forgot to add a changelog entry in #6157 – we need to add that to the blog post.

@duailibe
Copy link
Member Author

I'll add, thanks @lydell

@lipis lipis added this to the 1.19 milestone Sep 16, 2019
@fisker
Copy link
Sponsor Member

fisker commented Sep 16, 2019

Should we mention parser-postcss.js is now minified? #6395

@kachkaev
Copy link
Member

Would it be possible to wait for #6519 or can it be later released as 1.19.x?

Copy link

@nikulis nikulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small spelling, grammar things :)

website/blog/2019-09-25-1.19.0.md Outdated Show resolved Hide resolved
website/blog/2019-09-25-1.19.0.md Outdated Show resolved Hide resolved
website/blog/2019-09-25-1.19.0.md Outdated Show resolved Hide resolved
lipis and others added 4 commits September 27, 2019 13:18
Co-Authored-By: Nick Freeman <nick@nikulis.io>
Co-Authored-By: Nick Freeman <nick@nikulis.io>
Co-Authored-By: Nick Freeman <nick@nikulis.io>
@duailibe
Copy link
Member Author

I think any other updates should come in 1.20

@alexander-akait
Copy link
Member

alexander-akait commented Sep 30, 2019

@duailibe i disagree, all issues/PRs marked as 1.19 should be competed (some PRs are very important, for example #6033 and #6400). We can discuss what PRs can be removed from 1.19 milestone, but we can't ignore them or just saying other updates should come in 1.20.

@duailibe
Copy link
Member Author

duailibe commented Oct 1, 2019

@evilebottnawi Yes, what I meant was I don't think all the issues and PRs in the milestone need to be there and the release should not depend on that

@alexander-akait
Copy link
Member

alexander-akait commented Oct 2, 2019

@duailibe i think we should resolve this issue for 1.19, some of them is very important. We don’t do releases very often so developers will have to wait a long time and we won’t get feedback on some issues/PRs

@lipis
Copy link
Member

lipis commented Oct 30, 2019

All set.. we just need to update the blogpost, and there are not leftovers in the 1.19 milestone.

Co-Authored-By: Jed Fox <git@twopointzero.us>
@lydell
Copy link
Member

lydell commented Oct 31, 2019

I could finish this up this weekend, and probably do the release, too. Is it good to release on a weekend?

@duailibe Are you going to finish this, or should I take over?

@evilebottnawi @thorn0 @sosukesuzuki @fisker @brodybits Any comments?

@thorn0
Copy link
Member

thorn0 commented Oct 31, 2019

@lydell Don't forget that CHANGELOG.unreleased.md has been a little refined since this PR was created.

@lydell
Copy link
Member

lydell commented Oct 31, 2019

Yeah, I was thinking of starting from scratch from it.

@lydell
Copy link
Member

lydell commented Nov 2, 2019

Closing in favor of #6787.

@lydell lydell closed this Nov 2, 2019
@lipis lipis deleted the release-1.19 branch November 18, 2019 10:41
@lipis lipis restored the release-1.19 branch November 18, 2019 10:41
@lipis lipis deleted the release-1.19 branch November 18, 2019 10:42
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants