Update to TypeScript 3.7 #3275
Merged
Update to TypeScript 3.7 #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BAH! It appears prettier doesn't support the TypeScript 3.7 syntax features. It is fixed in master of prettier, but they haven't released it yet. |
|
It looks like prettier 1.19 is imminent which should include all the 3.7 syntax fixes, so I guess we should hold off on this until that is released. |
|
Could you raise an issue for the problematic asserts in std? |
Prettier@1.19.0 has been released now. |
|
Ok this now includes prettier 1.19 in If it passes it CI it should be ready to go @ry |
kitsonk
force-pushed
the
ts_37
branch
2 times, most recently
from
324e011
to
83607d6
Compare
|
@ry ok, I think I have fixed everything and this PR is ready now |
ry
approved these changes
Nov 13, 2019
Update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland#3273
ry
added a commit
to ry/deno
that referenced
this pull request
Nov 13, 2019
Mistakenly re-enabled in denoland#3275.
piscisaureus
pushed a commit
that referenced
this pull request
Nov 13, 2019
Mistakenly re-enabled in #3275.
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Dec 28, 2019
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland#3273
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Dec 28, 2019
Mistakenly re-enabled in denoland#3275.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland/deno#3273
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland/deno#3273
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland/deno#3273
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland/deno#3273
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland/deno#3273
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland/deno#3273
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland/deno#3273
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland/deno#3273
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
and update to prettier 1.19 Also, update `assert()` and remove not null assertions where possibly in `cli`. Closes denoland/deno#3273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, update
assert()and remove not null assertions where possibly incli. Lots of the not null assertions need to be removed instdthough.Closes #3273