Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-commit from precommit.md #16229

Merged
merged 1 commit into from Apr 28, 2024
Merged

Remove pre-commit from precommit.md #16229

merged 1 commit into from Apr 28, 2024

Conversation

louwers
Copy link
Contributor

@louwers louwers commented Apr 20, 2024

Description

Pre-commit has archived the prettier package with the following comment:

prettier made some changes that breaks plugins entirely

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@kbroch-rivosinc
Copy link

This mirror https://github.com/rbubley/mirrors-prettier appears to be continuing the support of the prettier git-hook for the pre-commit tool. I'm wondering if that could be considered for the replacement of https://github.com/pre-commit/mirrors-prettier instead of removing the documentation completely?

@louwers
Copy link
Contributor Author

louwers commented Apr 24, 2024

I would only consider that if it's added to the list of supported hooks. https://pre-commit.com/hooks.html

@kbroch-rivosinc
Copy link

I would only consider that if it's added to the list of supported hooks. https://pre-commit.com/hooks.html

pre-commit/pre-commit.com#957 🤞

@kachkaev
Copy link
Member

@kbroch-rivosinc let’s merge as is given that pre-commit/pre-commit.com#957 has been closed. If the situation changes, feel free to create a new PR with updates to the docs. Thanks for your effort to maintain pre-commit integration 🙌

@kachkaev kachkaev merged commit 470d04e into prettier:main Apr 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants