Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about pre-commit mirror versions to docs/precommit.md #14775

Closed
wants to merge 1 commit into from

Conversation

kaechele
Copy link

Description

Add notes on how to use prettier with the pre-commit mirror for when certain stable version tags are unavailable.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

Signed-off-by: Felix Kaechele <felix@kaechele.ca>
@louwers
Copy link
Contributor

louwers commented Apr 20, 2024

pre-commit no longer supports prettier, so this section can be removed entirely

#16229

@fisker
Copy link
Member

fisker commented Apr 20, 2024

I agree that we should just remove it if Prettier doesn't work with precommit anymore.

@kaechele kaechele closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants