Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Restricts preact.config.js's env types to a more idiomatic subset #1735

Merged
merged 5 commits into from Nov 18, 2022
Merged

types: Restricts preact.config.js's env types to a more idiomatic subset #1735

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11a1324
refactor: Begin to restrict config env types in prep for v4
rschristian Aug 13, 2022
1620f4d
docs: Adding changeset
rschristian Aug 13, 2022
bb7b7a5
Merge branch 'master' into types/restrict-config-env
rschristian Aug 17, 2022
10dc3da
Merge branch 'master' into types/restrict-config-env
rschristian Nov 17, 2022
3efc14d
Merge branch 'master' into types/restrict-config-env
rschristian Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/six-years-prove.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'preact-cli': patch
---

Restricts `preact.config.js`'s `env` types into a more idiomatic subset
11 changes: 2 additions & 9 deletions packages/cli/types.d.ts
View file
Open in desktop
Expand Up @@ -57,16 +57,9 @@ export type Config = {
* to check for in your config
*/
export type Env = {
src: string;
dest: string;
esm: boolean;
sw: boolean;
dev: boolean;
production: boolean;
isProd: boolean;
ssr: boolean;
prerender: boolean;
[key: string]: any;
isWatch: boolean;
isServer: boolean;
};

export type Helpers = {
Expand Down