types: Restricts preact.config.js
's env
types to a more idiomatic subset
#1735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor of
preact.config.js
typesDid you add tests for your changes?
N/A
Summary
Goes along with #1734
env
inpreact.config.js
is quite overloaded and has numerous semi-duplicated values:production
andisProd
,ssr
andisServer
, etc. I'd like to cut this down to justisProd
,isDev
, andisServer
in v4, but for now, a good start would be to restrict the types & update the wiki.At best, the types/values beyond these three (and their duplicates) are just convenience (not having to get the path for
src
yourself), and at worst, confuse new users.Does this PR introduce a breaking change?
No