fix: disable load manifest in dev #1711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfixes
Did you add tests for your changes?
Existing cover
Summary
Closes #1710
Looks like there's a race condition in the generation of the load manifest, where the asset manifest isn't guaranteed to exist yet. It's only been reproduced w/ HMR enabled, so that may be the key factor.
Regardless, this is only used to form preload tags, which is never done in dev. Therefore we can just skip the plugin outside of prod.
Does this PR introduce a breaking change?
I can't imagine anyone is consuming the load manifest themselves in dev, no. It's possible, but would be pretty weird and not really useful.