Reloading error sometimes #1710

drager · 2022-07-09T12:28:25Z

I'm not sure if this is a bug with hot reloading or not, but sometimes I'm getting the following error (happens a lot when I make some larger code changes).

 Build  [=============       ] 65% (19.3s) building<i> [webpack-dev-middleware] wait until bundle finished: /backtester
 Build  [==================  ] 90% (37.8s) additional chunk assets processing<e> [webpack-dev-middleware] TypeError: Cannot read property '_value' of undefined
<e>     at module.exports (/home/drager/development/tinker/tinker-web-app/node_modules/preact-cli/lib/lib/webpack/create-load-manifest.js:10:52)
<e>     at /home/drager/development/tinker/tinker-web-app/node_modules/preact-cli/lib/lib/webpack/push-manifest.js:12:22
<e>     at _next1 (eval at create (/home/drager/development/tinker/tinker-web-app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
<e>     at eval (eval at create (/home/drager/development/tinker/tinker-web-app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:51:1)
<e>     at emit (/home/drager/development/tinker/tinker-web-app/node_modules/fork-ts-checker-webpack-plugin/lib/index.js:274:17)
<e>     at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/drager/development/tinker/tinker-web-app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:47:1)
<e>     at Compiler.emitAssets (/home/drager/development/tinker/tinker-web-app/node_modules/webpack/lib/Compiler.js:491:19)
<e>     at onCompiled (/home/drager/development/tinker/tinker-web-app/node_modules/webpack/lib/Watching.js:51:19)
<e>     at /home/drager/development/tinkertinker-web-app/node_modules/webpack/lib/Compiler.js:681:15
<e>     at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/drager/development/tinker/tinker-web-app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
<e>     at /home/drager/development/tinker/tinker-web-app/node_modules/webpack/lib/Compiler.js:678:31
<e>     at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/drager/development/tinker/tinker-web-app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
<e>     at AsyncSeriesHook.lazyCompileHook (/home/drager/development/tinker/tinker-web-app/node_modules/tapable/lib/Hook.js:154:20)
<e>     at /home/drager/development/tinker/tinker-web-app/node_modules/webpack/lib/Compilation.js:1423:35
<e>     at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/drager/development/tinker/tinker-web-app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
<e>     at AsyncSeriesHook.lazyCompileHook (/home/drager/development/tinker/tinker-web-app/node_modules/tapable/lib/Hook.js:154:20)

Environment Info:
  System:
    OS: Linux 5.3 Ubuntu 18.04.6 LTS (Bionic Beaver)
    CPU: (4) x64 Intel(R) Core(TM) i5-4690K CPU @ 3.50GHz
  Binaries:
    Node: 16.4.0 - ~/.nvm/versions/node/v16.4.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.4.0/bin/yarn
    npm: 7.18.1 - ~/.nvm/versions/node/v16.4.0/bin/npm
  Browsers:
    Chrome: 103.0.5060.114
    Firefox: 102.0
  npmPackages:
    preact: ^10.3.1 => 10.9.0 
    preact-cli: ^3.4.0 => 3.4.0 
    preact-render-to-string: ^5.1.4 => 5.2.0 
    preact-router: ^4.0.1 => 4.0.1

The text was updated successfully, but these errors were encountered:

rschristian · 2022-07-09T12:50:04Z

Hm, looks to be a race condition with the asset manifest being generated:

preact-cli/packages/cli/lib/lib/webpack/create-load-manifest.js

Line 10 in 3f389c2

assets = JSON.parse(assets['asset-manifest.json']._value);

Preloading is prod-only, so that plugin should probably only be returning an empty object in dev.

drager · 2022-07-09T12:53:56Z

Hmm ok. I'm running via preact watch --refresh --port 3000".

rschristian · 2022-07-09T12:55:40Z

Let me know if you can reliably reproduce it, though I somewhat doubt that's possible. I assume another save/HMR tick fixes this?

I think an early return is all that's needed there, will try to get something together tomorrow.

Edit: Put a PR together. If you are willing, try applying the changes with something like patch-package and let me know how it goes.

drager · 2022-07-09T13:24:56Z

Let me know if you can reliably reproduce it, though I somewhat doubt that's possible. I assume another save/HMR tick fixes this?

I think an early return is all that's needed there, will try to get something together tomorrow.

Yeah, not sure how to cause it. Seems to happen more when I have code that contains errors... I actually need to restart the whole dev server to get it working again. It hangs for me...

I'll try using patch-package. Thanks!

drager · 2022-07-09T14:24:51Z

Used the patch for 1 hour now and didn't get any errors for this hour. Without the patch I got the error every now and then, so it seems to be working 🎉

egilll · 2022-07-21T14:14:31Z

I get this error every single time I introduce a TypeScript error (but only if Preact CLI has been running for a while; it does not appear when it's only been running for a few minutes).

My guess was therefore that this had something to do with the output from fork-ts-checker-webpack-plugin messing with the next plugin, even though that would be very strange behavior.

The error is not resolved by saving files again, instead I need to restart Preact CLI each time. In the meantime, Preact CLI will serve the old files, which is often quite confusing.

(I am running Preact Cli 3.4.0, TypeScript 3.9.9)

rschristian · 2022-07-22T08:50:26Z

TS errors have no impact on the dev server, no. Syntax errors in TS might, depending on the specific syntax issue.

Preact CLI will serve the old files, which is often quite confusing.

webpack-dev-server will. If the rebuild fails, it continues to server old content. I'm not aware of any way to configure this, but we do expose the entire Webpack config for you to do so if that is in fact possible.

Julioevm · 2022-07-27T08:28:34Z

I'm having the same issue

oliverfindl · 2022-07-27T19:24:09Z

Hello,

I'm also having this same issue.

Environment Info:
  System:
    OS: Linux 4.15 Ubuntu 16.04.7 LTS (Xenial Xerus)
    CPU: (4) x64 Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz
  Binaries:
    Node: 17.9.0 - /usr/bin/node
    Yarn: 1.22.15 - /usr/bin/yarn
    npm: 8.8.0 - /usr/bin/npm
  Browsers:
    Chrome: 103.0.5060.134
    Firefox: 88.0
  npmPackages:
    preact: ^10.6.6 => 10.10.0
    preact-cli: ^3.4.0 => 3.4.0
    preact-render-to-string: ^5.1.20 => 5.2.1
    preact-router: ^4.0.1 => 4.1.0

I can consistently reproduce it by re-declaring some type, e.g.:

type Test1 = any;
type Test1 = any;

Which throws kinda standard type error and after I fix it, e.g.:

type Test1 = any;
type Test2 = any;

Then Webpack hangs with error:

[webpack-dev-middleware] TypeError: Cannot read properties of undefined (reading '_value')
<e>     at module.exports (.../node_modules/preact-cli/lib/lib/webpack/create-load-manifest.js:10:52)
<e>     at .../node_modules/preact-cli/lib/lib/webpack/push-manifest.js:12:22
<e>     at _next1 (eval at create (.../node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
<e>     at eval (eval at create (.../node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:51:1)
<e>     at emit (.../node_modules/fork-ts-checker-webpack-plugin/lib/index.js:274:17)
<e>     at AsyncSeriesHook.eval [as callAsync] (eval at create (.../node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:47:1)
<e>     at Compiler.emitAssets (.../node_modules/webpack/lib/Compiler.js:491:19)
<e>     at onCompiled (.../node_modules/webpack/lib/Watching.js:51:19)
<e>     at .../node_modules/webpack/lib/Compiler.js:681:15
<e>     at AsyncSeriesHook.eval [as callAsync] (eval at create (.../node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
<e>     at .../node_modules/webpack/lib/Compiler.js:678:31
<e>     at AsyncSeriesHook.eval [as callAsync] (eval at create (.../node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
<e>     at AsyncSeriesHook.lazyCompileHook (.../node_modules/tapable/lib/Hook.js:154:20)
<e>     at .../node_modules/webpack/lib/Compilation.js:1423:35
<e>     at AsyncSeriesHook.eval [as callAsync] (eval at create (.../node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
<e>     at AsyncSeriesHook.lazyCompileHook (.../node_modules/tapable/lib/Hook.js:154:20)

And won't reload itself after another change. It needs to be killed and started again.

Fix mentioned above solves this issue for me.

Thanks.

rschristian · 2022-07-28T18:35:02Z

Fix released in v3.4.1.

Let me know if anyone still has any problems.

rschristian mentioned this issue Jul 9, 2022

fix: disable load manifest in dev #1711

Merged

ForsakenHarmony closed this as completed in #1711 Jul 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reloading error sometimes #1710

Reloading error sometimes #1710

drager commented Jul 9, 2022

rschristian commented Jul 9, 2022

drager commented Jul 9, 2022 •

edited

rschristian commented Jul 9, 2022 •

edited

drager commented Jul 9, 2022

drager commented Jul 9, 2022

egilll commented Jul 21, 2022

rschristian commented Jul 22, 2022

Julioevm commented Jul 27, 2022

oliverfindl commented Jul 27, 2022

rschristian commented Jul 28, 2022

Reloading error sometimes #1710

Reloading error sometimes #1710

Comments

drager commented Jul 9, 2022

rschristian commented Jul 9, 2022

drager commented Jul 9, 2022 • edited

rschristian commented Jul 9, 2022 • edited

drager commented Jul 9, 2022

drager commented Jul 9, 2022

egilll commented Jul 21, 2022

rschristian commented Jul 22, 2022

Julioevm commented Jul 27, 2022

oliverfindl commented Jul 27, 2022

rschristian commented Jul 28, 2022

drager commented Jul 9, 2022 •

edited

rschristian commented Jul 9, 2022 •

edited