refactor: build test suite #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 96df7de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
refactor/test-suite
branch
from
f8c49cc
to
b62c869
Compare
rschristian
commented
Mar 14, 2022
Comment on lines
+10
to
16
| try { | ||
| await symlink( | ||
| join(from, 'node_modules', name), | ||
| join(to, 'node_modules', name) | ||
| ); | ||
| } catch {} | ||
| } |
There was a problem hiding this comment.
In case this looks odd: when running multiple builds in the same test fixture (such as testing option: true & option: false together), symlinking would be triggered twice, as it's called on build. fs.symlink() throws if the symlink already exists, so we should catch & ignore those cases.
rschristian
force-pushed
the
refactor/test-suite
branch
2 times, most recently
from
49b2638
to
0f97190
Compare
ForsakenHarmony
approved these changes
Mar 29, 2022
rschristian
force-pushed
the
refactor/test-suite
branch
2 times, most recently
from
97b5bdd
to
324e0c2
Compare
Co-authored-by: Leah <github.leah@hrmny.sh>
rschristian
force-pushed
the
refactor/test-suite
branch
from
324e0c2
to
96df7de
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Minor bugfixes, mostly added tests
Did you add tests for your changes?
yes
Summary
Wasn't feeling comfortable with the Webpack v5 branch, so I took to writing tests.
This fixes two very minor issues:
--jsonflag usedprocess.cwd(), rather than CLI'scwd/The build suite still skips the
--cwd,--brotli, and--veboseflags.--cwdpowers our entire test suite, so it's a bit redundant to test--brotlidoesn't seem to work on a default app, not quite sure what it's supposed to do either. Static compression of assets? Might be up for removal.--verboseis not particularly useful, we don't hide many logs behind that. Just debug stack traces really. Not worth testing at the moment.I'm sure I'm still missing plenty of behaviors but this is a start, anyways.
Does this PR introduce a breaking change?
No