refactor: build test suite (#1670)

Co-authored-by: Leah <github.leah@hrmny.sh>
preactjs · Apr 15, 2022 · 7afd8bb · 7afd8bb
1 parent 0346549
commit 7afd8bb
Show file tree

Hide file tree

Showing 50 changed files with 522 additions and 223 deletions.
diff --git a/.changeset/purple-chefs-yell.md b/.changeset/purple-chefs-yell.md
@@ -0,0 +1,5 @@
+---
+'preact-cli': patch
+---
+
+Corrects 'build --json' ouput location and 'apple-touch-icon' will respect the publicPath automatically
diff --git a/packages/cli/lib/commands/build.js b/packages/cli/lib/commands/build.js
@@ -107,7 +107,7 @@ async function command(src, argv) {
 	let stats = await runWebpack(argv, false);
 
 	if (argv.json) {
-		await runWebpack.writeJsonStats(stats);
+		await runWebpack.writeJsonStats(cwd, stats);
 	}
 }
 

diff --git a/packages/cli/lib/lib/webpack/run-webpack.js b/packages/cli/lib/lib/webpack/run-webpack.js
@@ -122,8 +122,8 @@ function showStats(stats, isProd) {
 	return stats;
 }
 
-function writeJsonStats(stats) {
-	let outputPath = resolve(process.cwd(), 'stats.json');
+function writeJsonStats(cwd, stats) {
+	let outputPath = resolve(cwd, 'stats.json');
 	let jsonStats = stats.toJson({
 		json: true,
 		chunkModules: true,

diff --git a/packages/cli/lib/resources/template.html b/packages/cli/lib/resources/template.html
@@ -6,7 +6,7 @@
 		<meta name="viewport" content="width=device-width,initial-scale=1">
 		<meta name="mobile-web-app-capable" content="yes">
 		<meta name="apple-mobile-web-app-capable" content="yes">
-		<link rel="apple-touch-icon" href="/assets/icons/apple-touch-icon.png">
+		<link rel="apple-touch-icon" href="<%= htmlWebpackPlugin.files.publicPath %>assets/icons/apple-touch-icon.png">
 		<% preact.headEnd %>
 	</head>
 	<body>