fix: disable load manifest in dev #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ecdbda1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
commented
Jul 9, 2022
| @@ -146,7 +146,7 @@ async function clientConfig(env) { | |||
| 'process.env.ADD_SW': env.sw, | |||
| 'process.env.PRERENDER': env.prerender, | |||
| }), | |||
| new PushManifestPlugin(), | |||
| new PushManifestPlugin(env.isProd), | |||
There was a problem hiding this comment.
Moving this into the prod config seems like a better move at first glance, but renderHTMLPLugin depends on it being ran first so we need to keep it here.
ForsakenHarmony
approved these changes
Jul 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfixes
Did you add tests for your changes?
Existing cover
Summary
Closes #1710
Looks like there's a race condition in the generation of the load manifest, where the asset manifest isn't guaranteed to exist yet. It's only been reproduced w/ HMR enabled, so that may be the key factor.
Regardless, this is only used to form preload tags, which is never done in dev. Therefore we can just skip the plugin outside of prod.
Does this PR introduce a breaking change?
I can't imagine anyone is consuming the load manifest themselves in dev, no. It's possible, but would be pretty weird and not really useful.