Added feature to bind on stream emits via options #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds feature to:
request.defaults({
bindOn: { request: console.log }
});
kunagpal
requested changes
Jul 3, 2018
request.js
Outdated
|
|
||
| // bind default events sent via options | ||
| // additional postman feature starts | ||
| if (options.bindOn) { |
There was a problem hiding this comment.
I don't see request library doing it anywhere
|
@shamasis |
|
|
* master: Update test certificates 2.87.1 Update changelog 2.87.0 Replace hawk dependency with a local implemenation (request#2943)
|
TODO: Add tests before stable release (CodeCov should be happy) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature to:
request.defaults({
bindOn: { request: console.log }
});
PR Checklist:
npm testlocally and all tests are passing.PR Description