Merge pull request #18 from postmanlabs/feature/bindOn

Added feature to bind on stream emits via options 🎉

package.json

@@ -7,7 +7,7 @@
     "util",
     "utility"
   ],
-  "version": "2.86.1-postman.1",
+  "version": "2.86.1-postman.2-beta.1",
   "repository": {
     "type": "git",
     "url": "https://github.com/postmanlabs/postman-request.git"

request.js

@@ -133,11 +133,13 @@ util.inherits(Request, stream.Stream)
 
 // Debugging
 Request.debug = process.env.NODE_DEBUG && /\brequest\b/.test(process.env.NODE_DEBUG)
+
 function debug () {
   if (Request.debug) {
     console.error('REQUEST %s', util.format.apply(util, arguments))
   }
 }
+
 Request.prototype.debug = debug
 
 Request.prototype.init = function (options) {
@@ -150,6 +152,26 @@ Request.prototype.init = function (options) {
   }
   self.headers = self.headers ? copy(self.headers) : {}
 
+  // additional postman feature starts
+  // bind default events sent via options
+  if (options.bindOn) {
+    Object.keys(options.bindOn).forEach(function (eventName) {
+      !Array.isArray(options.bindOn[eventName]) && (options.bindOn[eventName] = [options.bindOn[eventName]])
+      options.bindOn[eventName].forEach(function (listener) {
+        self.on(eventName, listener)
+      })
+    })
+  }
+  if (options.once) {
+    Object.keys(options.once).forEach(function (eventName) {
+      !Array.isArray(options.bindOnce[eventName]) && (options.bindOnce[eventName] = [options.bindOnce[eventName]])
+      options.bindOnce[eventName].forEach(function (listener) {
+        self.once(eventName, listener)
+      })
+    })
+  }
+  // additional postman feature ends
+
   // Delete headers with value undefined since they break
   // ClientRequest.OutgoingMessage.setHeader in node 0.12
   for (var headerName in self.headers) {
@@ -436,6 +458,7 @@ Request.prototype.init = function (options) {
       }
     }
   }
+
   if (self.body && !isstream(self.body)) {
     setContentLength()
   }
@@ -513,9 +536,9 @@ Request.prototype.init = function (options) {
       }
     }
 
-  // self.on('pipe', function () {
-  //   console.error('You have already piped to this stream. Pipeing twice is likely to break the request.')
-  // })
+    // self.on('pipe', function () {
+    //   console.error('You have already piped to this stream. Pipeing twice is likely to break the request.')
+    // })
   })
 
   defer(function () {
@@ -735,6 +758,9 @@ Request.prototype.start = function () {
     return
   }
 
+  // postman: emit start event
+  self.emit('start')
+
   self._started = true
   self.method = self.method || 'GET'
   self.href = self.uri.href
@@ -887,7 +913,7 @@ Request.prototype.onRequestError = function (error) {
   }
   if (self.req && self.req._reusedSocket && error.code === 'ECONNRESET' &&
     self.agent.addRequestNoreuse) {
-    self.agent = { addRequest: self.agent.addRequestNoreuse.bind(self.agent) }
+    self.agent = {addRequest: self.agent.addRequestNoreuse.bind(self.agent)}
     self.start()
     self.req.end()
     return
@@ -964,7 +990,7 @@ Request.prototype.onRequestResponse = function (response) {
   // XXX This is different on 0.10, because SSL is strict by default
   if (self.httpModule === https &&
     self.strictSSL && (!response.hasOwnProperty('socket') ||
-    !response.socket.authorized)) {
+      !response.socket.authorized)) {
     debug('strict ssl error', self.uri.href)
     var sslErr = response.hasOwnProperty('socket') ? response.socket.authorizationError : self.uri.href + ' does not support SSL'
     self.emit('error', new Error('SSL Error: ' + sslErr))
@@ -1122,7 +1148,7 @@ Request.prototype.onRequestResponse = function (response) {
 
 Request.prototype.readResponseBody = function (response) {
   var self = this
-  debug("reading response's body")
+  debug('reading response\'s body')
   var buffers = []
   var bufferLength = 0
   var strings = []