Fix usage of default exports with TypeScript #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by assigning the property `default` for all properties that are exported using `export default` according to their type definitions. Closes #1424
This options looses type strictness. This causes TypeScript tests to work, but that doesn’t mean the same imports would work for users who don’t use `esModuleInterop`.
This reverts commit e738254. The current ESLint setup conflicts with itself when using `import stripAnsi = require('strip-ansi')`, which is what should actually be used.
|
Released in 8.1.7 |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by assigning the property
defaultfor all properties that are exported usingexport defaultaccording to their type definitions.Closes #1424