Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno vs PostCSS 8.1.7 #1460

Closed
ai opened this issue Nov 10, 2020 · 5 comments
Closed

Deno vs PostCSS 8.1.7 #1460

ai opened this issue Nov 10, 2020 · 5 comments
Labels

Comments

@ai
Copy link
Member

ai commented Nov 10, 2020

Recent ES imports TS fix killed Deno build.

@oscarotero we need your help

4777548-tec60feb1942

@ai ai added the bug label Nov 10, 2020
@oscarotero
Copy link
Contributor

😄 mmm, weird. Let me investigate...

@oscarotero
Copy link
Contributor

oscarotero commented Nov 11, 2020

After spending some hours researching, I found that this error only happens in deno 1.5.1 and upper (in deno 1.5.0 works fine). And seems like this only happens by running the tests, but the library seems to work fine.

A workaround may be disabling the tests in the github action or, at least, force to install Deno 1.5.0 (it can be configured here: https://github.com/postcss/postcss/blob/master/.github/workflows/deno.yml#L16)

I'm going to create an issue in Deno repository.

@oscarotero
Copy link
Contributor

Bug reported here: denoland/deno#8355

@oscarotero
Copy link
Contributor

Ok, I've updated the deno conversion to remove the changes introduced in 8.1.7, like CssSyntaxError.default = CssSyntaxError;

There's an open issue (denoland/deno#8355) to fix this problem in Deno, but meanwhile I've removed here:
https://github.com/postcss/postcss-deno/blob/master/to_deno.js#L29

So, once this #1474 is merged, I think Deno conversion should work again.

@ai
Copy link
Member Author

ai commented Nov 24, 2020

Thanks!

@ai ai closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants