Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of default exports with TypeScript #1459

Merged
merged 3 commits into from Nov 10, 2020
Merged

Fix usage of default exports with TypeScript #1459

merged 3 commits into from Nov 10, 2020

Commits on Nov 10, 2020

  1. Fix usage of default exports with TypeScript 

    This is done by assigning the property `default` for all properties that are
exported using `export default` according to their type definitions.

Closes #1424
    @remcohaszing
    remcohaszing committed Nov 10, 2020
    Copy the full SHA
    8741fdd View commit details
    Browse the repository at this point in the history

  2. Remove esModuleInterop option from tsconfig.json 

    This options looses type strictness. This causes TypeScript tests to work, but
that doesn’t mean the same imports would work for users who don’t use
`esModuleInterop`.
    @remcohaszing
    remcohaszing committed Nov 10, 2020
    Copy the full SHA
    e738254 View commit details
    Browse the repository at this point in the history

  3. Revert "Remove esModuleInterop option from tsconfig.json" 

    This reverts commit e738254.

The current ESLint setup conflicts with itself when using
`import stripAnsi = require('strip-ansi')`, which is what should actually be
used.
    @remcohaszing
    remcohaszing committed Nov 10, 2020
    Copy the full SHA
    97a41a8 View commit details
    Browse the repository at this point in the history