Implement dynamic navs #90
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
dynamic-navs
branch
3 times, most recently
from
75581bd
to
3611c13
Compare
cpsievert
force-pushed
the
dynamic-navs
branch
2 times, most recently
from
63e314d
to
94dab30
Compare
cpsievert
force-pushed
the
dynamic-navs
branch
4 times, most recently
from
2eab208
to
e3f139c
Compare
cpsievert
force-pushed
the
dynamic-navs
branch
2 times, most recently
from
942604f
to
c923440
Compare
cpsievert
force-pushed
the
server-side-navs
branch
from
ea6dddc
to
ecbe0af
Compare
cpsievert
force-pushed
the
dynamic-navs
branch
2 times, most recently
from
d627256
to
2eaebf8
Compare
cpsievert
force-pushed
the
server-side-navs
branch
from
ecbe0af
to
bfdc2e9
Compare
cpsievert
force-pushed
the
server-side-navs
branch
from
f228178
to
0bec791
Compare
cpsievert
force-pushed
the
dynamic-navs
branch
2 times, most recently
from
05644ec
to
e5b2542
Compare
cpsievert
commented
Apr 26, 2022
shiny/_modules.py
Outdated
Comment on lines
120
to
121
| def send_input_message(self, id: str, message: Dict[str, object]) -> None: | ||
| return super().send_input_message(self.ns(id), message) |
There was a problem hiding this comment.
This part is what closes #99...happy to do this in a follow PR if preferred
cpsievert
force-pushed
the
dynamic-navs
branch
6 times, most recently
from
8d5dbc6
to
affed80
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89
Closes #99
TODO
Does it make sense for their to be aEdit @jcheng5 2023-05-22: I thinkns()method on theSession/ModuleSession?resolve_idis how this works now.nav_prependandnav_appendthat are thin wrappers overnav_insert; takes too much thought to achieve these 99% cases otherwise