Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic tabs #499

Open
jcheng5 opened this issue May 21, 2023 · 6 comments
Open

Dynamic tabs #499

jcheng5 opened this issue May 21, 2023 · 6 comments

Comments

@jcheng5
Copy link
Collaborator

jcheng5 commented May 21, 2023

Requested by @Dene33 via Twitter DMs. I think most of the complexity is already in the client so hopefully this is just a matter of writing some thin Python wrappers

@cpsievert
Copy link
Collaborator

FWIW, there is a draft in #90 (IIRC, it ended up getting blocked by modules, so it'll probably need some updates to work properly w/ modules)

@Dene33
Copy link

Dene33 commented May 21, 2023

Thanks, @cpsievert I'll give it a try. It should work if no modules are present in the project, right?

@Dene33
Copy link

Dene33 commented May 22, 2023

Tried to apply #90 on top of the main branch but it seems the draft is too old to work out of the box unfortunately. :(

@jcheng5
Copy link
Collaborator Author

jcheng5 commented May 22, 2023

@Dene33 I just rebased and force-pushed (edit: and updated the modules-related code), can you try again?

Also it should work with modules now, although I haven't had a chance to test it yet.

@Dene33
Copy link

Dene33 commented May 25, 2023

@jcheng5 Sorry for the late reply. I gave it a try, and everything is working great (except for the modules, I haven't tested those yet). Thanks a lot!

@jrgrohs
Copy link

jrgrohs commented Jun 6, 2023

I'm sorry for the naive question (I'm new to Github and Shiny for Python/ShinyLive) but does this thread mean that I can try this functionality as now available or not quite? Or is there an easy way to load this before it gets rolled into the main branch?

I was trying to sort this out on my own but was having trouble implementing anything but a brute force solution. My hope it to have a navset_tab_card with a fixed tab with a list of checkbox items and as you choose some of those checkbox items it creates extra tabs for the specific checked boxes. I started a brute force method of combinations of the checkbox entries but then searched and saw this entry and it seems that is more or less the feature you have worked on with nav_append()?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants