General refactor #31
Closed
General refactor #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"babel-plugin-add-module-exports" plugin adds the module.exports property onto exported babel files with a single default export. This allows interoperability between Babel 6 and Webpack 1.
This looks a little messy but allows for running the tests on all OSs with the choice of reinstalling dependencies.
Probably should have done this when I bumped the config version.
This file is used by yarn to ensure that all developers are using the correct dependency versions.
Also fixed a test to actually test what it was meant to test.
|
@rmp135 Hey mate — thanks for the PR! Have given it a quick look over, looks like a really nice little cleanup! :) Will try and find some time to pull it down properly and have a look in more detail today. |
|
What's the status on this? |
|
@rmp135 Sorry — I’ve been AFK for a bit and have not got around to it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially went to fix a bug with inject-loader breaking methods that were named "require" (e.g. electron.require("...")) and one thing led to another...
Anyway, the codebase can be tested in a much cleaner way with a lot less plumbing between the various parts. The tests have been fleshed out and unnecessary dependencies trimmed.
The original webpack1 and webpack2 integration tests are still in place and pass.