Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge injectify-loader and inject-loader #36

Merged
merged 12 commits into from Mar 19, 2017

Conversation

vladimir-tikhonov
Copy link
Collaborator

@vladimir-tikhonov vladimir-tikhonov commented Mar 18, 2017

Fixes #32

I've removed flow typings because I'm not familiar with flow and don't think that it will help much on such small project. Hovewer I can try to add them back if you want.
Feel free to ask any questions or request changes.

@vladimir-tikhonov
Copy link
Collaborator Author

vladimir-tikhonov commented Mar 18, 2017

I've added additional test in 0831925 to ensure that we don't break obj.require() calls (issue mentioned in #31). cc @rmp135

@vladimir-tikhonov vladimir-tikhonov force-pushed the injectify-loader-integration branch 2 times, most recently from 746fe01 to e7dc6f9 Compare March 18, 2017 13:28
@vladimir-tikhonov
Copy link
Collaborator Author

vladimir-tikhonov commented Mar 18, 2017

Commit b579460 adds sourcemaps support (fixes #10)

@plasticine
Copy link
Owner

@vladimir-tikhonov This is phenomenal stuff — great work, huge effort! 👏

I’ve made a few really minor tweaks to some of the tooling and example code, but the actual library code is perfect! 👌

If you’re happy then let’s ship this and release it as 3.0.

@plasticine
Copy link
Owner

plasticine commented Mar 19, 2017

@vladimir-tikhonov apologies for the few broken commits there, looks like there were a few issues with the example/integration tests and packaging code.

@vladimir-tikhonov
Copy link
Collaborator Author

Good catches, @plasticine 👍

@vladimir-tikhonov vladimir-tikhonov merged commit d005d1f into master Mar 19, 2017
@vladimir-tikhonov vladimir-tikhonov deleted the injectify-loader-integration branch March 19, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants