Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to current setuptools best practice #84

Merged
merged 6 commits into from Oct 22, 2019
Merged

Update to current setuptools best practice #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6576af4
setup.py install is deprecated
jamesmyatt Oct 22, 2019
1581605
Remove test alias from setup.cfg
jamesmyatt Oct 22, 2019
d85a1ff
setup.py test is deprecated
jamesmyatt Oct 22, 2019
4d9eb98
setup.py install is deprecated
jamesmyatt Oct 22, 2019
685d1a5
setup.py test is deprecated
jamesmyatt Oct 22, 2019
0452709
setup.py install is deprecated
jamesmyatt Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.rst
View file
Open in desktop
Expand Up @@ -103,7 +103,7 @@ Ready to contribute? Here's how to set up `picknmix` for local development.
tests, including testing other Python versions with tox::

$ flake8 picknmix tests
$ python setup.py test or pytest
$ python pytest tests
$ tox

To get flake8 and tox, just pip install them into your virtualenv.
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Expand Up @@ -85,4 +85,4 @@ dist: clean ## builds source and wheel package
ls -l dist

install: clean ## install the package to the active Python's site-packages
python setup.py install
python -m pip install .
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Expand Up @@ -92,7 +92,7 @@ From sources

::

$ python setup.py install
$ python -m pip install .

Usage
-----
Expand Down
2 changes: 1 addition & 1 deletion docs/installation.rst
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@ Once you have a copy of the source, you can install it with:

.. code-block:: console

$ python setup.py install
$ python -m pip install .


.. _Github repo: https://github.com/Cheukting/picknmix
Expand Down
4 changes: 0 additions & 4 deletions setup.cfg
View file
Open in desktop
Expand Up @@ -17,9 +17,5 @@ universal = 1
[flake8]
exclude = docs

[aliases]
test = pytest

[tool:pytest]
collect_ignore = ['setup.py']

9 changes: 2 additions & 7 deletions setup.py
View file
Open in desktop
Expand Up @@ -12,10 +12,7 @@
history = history_file.read()

requirements = []

setup_requirements = ['pytest-runner', ]

test_requirements = ['pytest', 'scikit-learn>=0.21.2']
extras_requirements = {'test': ['pytest', 'scikit-learn>=0.21.2']}

setup(
author="Cheuk Ting Ho",
Expand Down Expand Up @@ -43,9 +40,7 @@
keywords='picknmix',
name='picknmix',
packages=find_packages(include=['picknmix']),
setup_requires=setup_requirements,
test_suite='tests',
tests_require=test_requirements,
extras_require=extras_requirements,
url='https://github.com/Cheukting/picknmix',
version='0.1.3',
python_requires=">=3.5",
Expand Down