Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to current setuptools best practice #84

Merged
merged 6 commits into from Oct 22, 2019
Merged

Update to current setuptools best practice #84

merged 6 commits into from Oct 22, 2019

Conversation

jamesmyatt
Copy link
Contributor

@jamesmyatt jamesmyatt commented Oct 22, 2019 •
edited

@jamesmyatt jamesmyatt changed the title [WIP] Update to current setuptools best practice Update to current setuptools best practice Oct 22, 2019
Cheukting
Cheukting reviewed Oct 22, 2019
View reviewed changes
Copy link
Member

@Cheukting Cheukting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Thanks for spoting it.

@Cheukting Cheukting merged commit 6991ee1 into picknmix:master Oct 22, 2019
@jamesmyatt jamesmyatt deleted the jamesmyatt-patch-1 branch October 22, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheukting Cheukting Cheukting left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamesmyatt @Cheukting