Accept derived template types #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Hold on, I'm looking into the failures. |
|
Oh yes, the fact these errors move to level 7 is actually nice. |
|
I'm not 100% sure about this PR, though. There may be some scenarios where the type will not be correct. |
|
It's fine, it's better than before and users will let us know if we missed something sooner or later :) |
|
phpstan-symfony still failing, I'm looking into it, otherwise it's good! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template types in non-parameter locations are extra strict about what they accept, as they will only accept a type strictly equal to themselves (same name, scope, bound, and implementation).
This PR relaxes this a bit so that template types recognizes that they can be derived. They will now accept an other template type with equal name+scope and whose bound is a sub-type of the accepting type's bound.
I believe that this is still correct because as long as two template types have the same name+scope, they are in fact the same type.
This fixes phpstan/phpstan#5844 and phpstan/phpstan#5706.