False positive: Access to an undefined property T of A|B|C::$name (regression)

[LastDragon-ru]

Bug report

Error appeared after

• Upgrading phpstan/phpstan (dev-master 90cdfea => dev-master 9747308)

v1.4.5 is fine

Code snippet that reproduces the problem

https://phpstan.org/r/cd4aa1fe-61dc-46c6-bfd5-931540ab74e4

Expected output

no error

Did PHPStan help you today? Did it make you happy in any way?

Yep, it found one very stupid typo...

[ondrejmirtes]

Thank you very much for trying out dev-master and finding this bug! Although I hope you're using a stable version in your usual day-to-day work :)

/cc @arnaud-lb I will try to improve tryRemove in TemplateUnionType, I have some ideas about that. Also I suspect we'll need to have Type::tryIntersect so I'll try to do it as well. I'll reach back if I'm gonna need some assistance with that :)

[arnaud-lb]

@ondrejmirtes it may be safe to apply ::remove() on the bound and return a new template type with that bound, since ::remove() narrows the type. With phpstan/phpstan-src#999, the resulting template type will also still be accepted by the original template type.

[ondrejmirtes]

Yeah, that's exactly what I want to do. I'm a bit surprised that intersection works already: https://phpstan.org/r/da79b871-df02-47e0-99f4-9561f2949499

[ondrejmirtes]

Fixed: phpstan/phpstan-src@0d28835

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.