Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the return types of round()/ceil()/floor() #729

Merged
merged 17 commits into from Feb 3, 2022
Merged

Fix the return types of round()/ceil()/floor() #729

merged 17 commits into from Feb 3, 2022

Commits on Feb 2, 2022

  1. These functions can also return boolean false.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    ae3b340 View commit details
    Browse the repository at this point in the history

  2. Add tests for rounding function return types.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    95aa585 View commit details
    Browse the repository at this point in the history

  3. Use strict comparison in in_array().

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1246fc1 View commit details
    Browse the repository at this point in the history

  4. Coding standards fixes.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    41ad8cd View commit details
    Browse the repository at this point in the history

  5. More test cases.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    cb697fb View commit details
    Browse the repository at this point in the history

  6. Account for all array types.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    c081b6c View commit details
    Browse the repository at this point in the history

  7. Add handling for different behaviour of the rounding functions in PHP 8.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    dab8b0f View commit details
    Browse the repository at this point in the history

  8. Correct the never type.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    08cc859 View commit details
    Browse the repository at this point in the history

  9. Correct the return type when no parameter is passed.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1b705e8 View commit details
    Browse the repository at this point in the history

  10. Correctly account for an unknown parameter type.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    377b0a0 View commit details
    Browse the repository at this point in the history

  11. Fix a typo.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    abf584e View commit details
    Browse the repository at this point in the history

  12. Add tests for float|int union type.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    bb03562 View commit details
    Browse the repository at this point in the history

  13. Handle an integer and float union.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    d071c3e View commit details
    Browse the repository at this point in the history

  14. Docs.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    87d286f View commit details
    Browse the repository at this point in the history

  15. Coding standards.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    3a486a9 View commit details
    Browse the repository at this point in the history

  16. Switch to injecting the PHP version logic.

    @johnbillion @ondrejmirtes
    johnbillion authored and ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    d916dd3 View commit details
    Browse the repository at this point in the history

  17. Fix CS

    @ondrejmirtes
    ondrejmirtes committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    eaad325 View commit details
    Browse the repository at this point in the history