Fix the return types of round()/ceil()/floor() #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Oct 24, 2021
|
I'm not sure what the failing tests are telling me. They seem unrelated to this change but I don't have a good enough understanding of PHPStan internals to know for sure. Guidance appreciated. |
|
I'd love to use this, can you please rebase and make the build green? Thank you. |
johnbillion
force-pushed
the
rounding-return-types
branch
from
ada463a
to
36fc0d5
Compare
|
There's still a lot of failures. |
|
It's difficult to determine what's failing due to this change and what's also failing in master currently. I'll wait until master is green then take another look. |
|
Yeah, you can safely rebase now :) |
johnbillion
force-pushed
the
rounding-return-types
branch
from
36fc0d5
to
d2b50e3
Compare
ondrejmirtes
requested changes
Feb 2, 2022
ondrejmirtes
force-pushed
the
rounding-return-types
branch
from
930a5de
to
d916dd3
Compare
ondrejmirtes
approved these changes
Feb 3, 2022
|
Thank you! |
|
Thanks for helping get it over the finishing line :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PHP < 8 these functions return boolean false when the
$numparameter is an array: https://3v4l.org/J9KkPPHPStan correctly reports an error if the type of
$numis known and notint|float, but it's possible for the type not to be known.This playground example is as good as I could manage: https://phpstan.org/r/59f77cf2-a658-4f2b-9630-80c778714ab2