Added ImplodeFunctionRule #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build error is unrelated |
ondrejmirtes
requested changes
Sep 21, 2021
ondrejmirtes
requested changes
Sep 21, 2021
…into implode-array
staabm
changed the title
ondrejmirtes
requested changes
Sep 22, 2021
| return []; | ||
| } | ||
|
|
||
| if ($arrayType->getIterableValueType()->toString() instanceof ErrorType) { |
There was a problem hiding this comment.
We should also employ RuleLevelHelper::findTypeToCheck so that partially-wrong unions aren't reported until level 7.
Ther are many usages of that method, look through the codebase.
There was a problem hiding this comment.
adjusted. seems to work. does this require some kind of unit-test?
I am not sure yet, which case this new logic supports, which the previous didn't.
There was a problem hiding this comment.
Check out LevelsIntegrationTest, add something in acceptTypes.php, and re-run this test case. The JSON snapshots will be updated.
There was a problem hiding this comment.
thx, I guess it works now.
ondrejmirtes
requested changes
Sep 22, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#5596