Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implode should error out when the second argument is a multidimensional array #5596

Closed
notdian opened this issue Sep 6, 2021 · 3 comments · Fixed by phpstan/phpstan-src#679
Closed

Implode should error out when the second argument is a multidimensional array #5596

notdian opened this issue Sep 6, 2021 · 3 comments · Fixed by phpstan/phpstan-src#679
Labels
feature-request

Comments

@notdian
Copy link

notdian commented Sep 6, 2021

Bug report

implode('',['12','123',['1234','12345']]) doesn't error raise any exceptions.
@mergeable
Copy link

mergeable bot commented Sep 6, 2021

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

@staabm staabm mentioned this issue Sep 20, 2021
Merged
@ondrejmirtes
Copy link
Member

Implemented by: phpstan/phpstan-src#679

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added ImplodeFunctionRule staabm/phpstan-src
2 participants
@ondrejmirtes @notdian