Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various type-related fixes #341

Merged
merged 3 commits into from Oct 14, 2020
Merged

Conversation

jlherren
Copy link
Contributor

No description provided.

@ondrejmirtes
Copy link
Member

Thank you, I love it! Do those bugs have already existing GitHub issues or are these new ones?

@jlherren
Copy link
Contributor Author

I was trying to fix some GitHub issues when I found that I don't entirely understand the fine details of TypeSpecifier and the Type class hierarchy. To study it I ended up writing a fuzz test, where it would randomly choose types A and B and test invariants on them. For example intersect(A, B) should always be the same as remove(A, remove(mixed, B)). And then it started failing for some type combinations :)

I can make a PR for that fuzz test later on.

@ondrejmirtes
Copy link
Member

I’d really like these fuzz tests in the test suite, thank you 😊

@ondrejmirtes ondrejmirtes merged commit 8c13aea into phpstan:master Oct 14, 2020
@jlherren jlherren deleted the type-fixes branch October 14, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants