Fix intersection of iterable and array

phpstan · Oct 14, 2020 · 8c13aea · 8c13aea
1 parent 4a74d7c
commit 8c13aea
Show file tree

Hide file tree

Showing 3 changed files with 64 additions and 2 deletions.
diff --git a/src/Type/IterableType.php b/src/Type/IterableType.php
@@ -34,6 +34,11 @@ public function __construct(
 		$this->itemType = $itemType;
 	}
 
+	public function getKeyType(): Type
+	{
+		return $this->keyType;
+	}
+
 	public function getItemType(): Type
 	{
 		return $this->itemType;

diff --git a/src/Type/TypeCombinator.php b/src/Type/TypeCombinator.php
@@ -738,11 +738,28 @@ public static function intersect(Type ...$types): Type
 					if ($types[$i] instanceof ConstantArrayType && $types[$j] instanceof HasOffsetType) {
 						$types[$i] = $types[$i]->makeOffsetRequired($types[$j]->getOffsetType());
 						array_splice($types, $j--, 1);
+						continue;
 					}
 
 					if ($types[$j] instanceof ConstantArrayType && $types[$i] instanceof HasOffsetType) {
 						$types[$j] = $types[$j]->makeOffsetRequired($types[$i]->getOffsetType());
 						array_splice($types, $i--, 1);
+						continue 2;
+					}
+
+					if (
+						($types[$i] instanceof ArrayType || $types[$i] instanceof IterableType) &&
+						($types[$j] instanceof ArrayType || $types[$j] instanceof IterableType)
+					) {
+						$keyType = self::intersect($types[$i]->getKeyType(), $types[$j]->getKeyType());
+						$itemType = self::intersect($types[$i]->getItemType(), $types[$j]->getItemType());
+						if ($types[$i] instanceof IterableType && $types[$j] instanceof IterableType) {
+							$types[$j] = new IterableType($keyType, $itemType);
+						} else {
+							$types[$j] = new ArrayType($keyType, $itemType);
+						}
+						array_splice($types, $i--, 1);
+						continue 2;
 					}
 
 					continue;

diff --git a/tests/PHPStan/Type/TypeCombinatorTest.php b/tests/PHPStan/Type/TypeCombinatorTest.php
@@ -2002,8 +2002,48 @@ public function dataIntersect(): array
 					new ArrayType(new MixedType(), new MixedType()),
 					new IterableType(new MixedType(), new StringType()),
 				],
-				IntersectionType::class,
-				'array&iterable<string>', // this is correct but 'array<string>' would be better
+				ArrayType::class,
+				'array<string>',
+			],
+			[
+				[
+					new ArrayType(new IntegerType(), new MixedType()),
+					new IterableType(new MixedType(), new StringType()),
+				],
+				ArrayType::class,
+				'array<int, string>',
+			],
+			[
+				[
+					new ArrayType(new IntegerType(), new MixedType()),
+					new IterableType(new StringType(), new MixedType()),
+				],
+				NeverType::class,
+				'*NEVER*',
+			],
+			[
+				[
+					new ArrayType(new MixedType(), new IntegerType()),
+					new IterableType(new MixedType(), new StringType()),
+				],
+				NeverType::class,
+				'*NEVER*',
+			],
+			[
+				[
+					new ArrayType(new IntegerType(), new MixedType()),
+					new ArrayType(new MixedType(), new StringType()),
+				],
+				ArrayType::class,
+				'array<int, string>',
+			],
+			[
+				[
+					new IterableType(new IntegerType(), new MixedType()),
+					new IterableType(new MixedType(), new StringType()),
+				],
+				IterableType::class,
+				'iterable<int, string>',
 			],
 			[
 				[