Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare FileReadTrapStreamWrapper::$context property #2153

Closed
wants to merge 3 commits into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 29, 2022

should fix warnings like

 Deprecated: Creation of dynamic property                                   
     PHPStan\Reflection\BetterReflection\SourceLocator\FileReadTrapStreamWrapper::$context is deprecated in                                              
     /home/runner/work/redaxo/redaxo/redaxo/src/core/lib/autoload.php on line       256                                                                        

this property is defined in the streamwrapper prototype and when missing creates a runtime warning


the fix is related to phpstan/phpstan#8610 but will not fix said issue

@staabm staabm marked this pull request as ready for review December 29, 2022 13:44
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes
Copy link
Member

This needs a reproduction first. Here's an example how to reproduce open_basedir issues in an integration test: phpstan/phpstan#7518

@staabm
Copy link
Contributor Author

staabm commented Dec 29, 2022

I tried a lot of different things but the warning did not reproduce.

maybe this fix is obsolete with #2154.. lets see

@ondrejmirtes
Copy link
Member

Well if you have a project where you see it, it should be easy to reduce the project to something small that still shows it.

@ondrejmirtes
Copy link
Member

I expect #2154 to fix the problem, because there's just one reproducer -> one PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants