Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test expectations of bug 8610 reproducer #8613

Merged
merged 2 commits into from Dec 29, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 29, 2022

as noted in phpstan/phpstan-src#2154 (comment)

I tested locally that the test still fails without the fix from phpstan/phpstan-src#2154 and succeeds with the fix applied


running the test with php 8.2 revealed the warning for phpstan/phpstan-src#2153

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the correct regexp. Just generate and include the baseline please.

@staabm
Copy link
Contributor Author

staabm commented Dec 29, 2022

sorry - fixed

@ondrejmirtes ondrejmirtes merged commit dc3cbbb into phpstan:1.9.x Dec 29, 2022
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants