Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result cache should not be invalidated by changes to editorUrl, editorUrlTitle and errorFormat parameters #2136

Merged
merged 1 commit into from Dec 21, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Analyser/ResultCache/ResultCacheManager.php
Expand Up @@ -734,6 +734,9 @@ private function getMeta(array $allAnalysedFiles, ?array $projectConfigArray): a
sort($extensions);

if ($projectConfigArray !== null) {
unset($projectConfigArray['parameters']['editorUrl']);
unset($projectConfigArray['parameters']['editorUrlTitle']);
unset($projectConfigArray['parameters']['errorFormat']);
unset($projectConfigArray['parameters']['ignoreErrors']);
unset($projectConfigArray['parameters']['tipsOfTheDay']);
unset($projectConfigArray['parameters']['parallel']);
Expand Down