Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result cache should not be invalidated by changes to editorUrl, editorUrlTitle and errorFormat parameters #2136

Merged
merged 1 commit into from Dec 21, 2022
Merged

Result cache should not be invalidated by changes to editorUrl, editorUrlTitle and errorFormat parameters #2136

merged 1 commit into from Dec 21, 2022

Conversation

bendavies
Copy link
Contributor

@bendavies bendavies commented Dec 21, 2022 •
edited

  • Result cache should not be invalidated by changes to editorUrl and editorUrlTitle parameters

ondrejmirtes
ondrejmirtes requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also errorFormat can be unset.

@bendavies bendavies changed the title Result cache should not be invalidated by changes to editorUrl and editorUrlTitle parameters Result cache should not be invalidated by changes to editorUrl, editorUrlTitle and errorFormat parameters Dec 21, 2022
@ondrejmirtes ondrejmirtes merged commit 51774ef into phpstan:1.9.x Dec 21, 2022
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bendavies @ondrejmirtes