Show combined memory usage in parallel mode #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janedbal
commented
Nov 23, 2022
| @@ -221,6 +227,7 @@ public function analyse( | |||
| $internalErrorsCount === 0 ? $dependencies : null, | |||
| $exportedNodes, | |||
| $reachedInternalErrorsCountLimit, | |||
| (int) array_sum($peakMemoryUsages), // not 100% correct as the peak usages of workers might not have met | |||
There was a problem hiding this comment.
I dont think there is a better option. Still imo much better than before. It seems working well when comparing with system memory used.
There was a problem hiding this comment.
Tested against linux ps and it gives very good results, almost equal.
janedbal
added a commit
to janedbal/phpstan
that referenced
this pull request
Nov 24, 2022
janedbal
force-pushed
the
peak-memory-usage
branch
from
d7ea71b
to
a3160a6
Compare
janedbal
commented
Dec 1, 2022
| }, $handleError, function ($exitCode, string $output) use (&$internalErrors, &$internalErrorsCount, $processIdentifier): void { | ||
| }, $handleError, function ($exitCode, string $output) use (&$someChildEnded, &$peakMemoryUsages, &$internalErrors, &$internalErrorsCount, $processIdentifier): void { | ||
| if ($someChildEnded === false) { | ||
| $peakMemoryUsages['main'] = memory_get_usage(true); |
There was a problem hiding this comment.
This is the point of time where phpstan consumes most memory (I believe in >99% cases), so I add main thread memory at that specific time.
janedbal
force-pushed
the
peak-memory-usage
branch
from
6220763
to
555ceb1
Compare
janedbal
force-pushed
the
peak-memory-usage
branch
from
38ebd85
to
f706989
Compare
ondrejmirtes
force-pushed
the
peak-memory-usage
branch
from
f706989
to
21a14dd
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#4683
Looks like this: