Pre-tagged unions #1548
Merged
Pre-tagged unions #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
force-pushed
the
pre-tagged-unions
branch
from
09173a5
to
c755706
Compare
ondrejmirtes
force-pushed
the
pre-tagged-unions
branch
from
c755706
to
2873e1b
Compare
|
FYI @herndlm this contains new HasOffsetValueType. I'm not certain it's gonna help you to improve in_array() but you can try it :) |
|
It was so painful and hard to come up with something that works and doesn't break much stuff, the PHPStan issue bot comment flood is so worth it though :) |
|
So worth it :)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.