Tagged unions #1547
Merged
Tagged unions #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
force-pushed
the
tagged-unions
branch
from
fe9f2e1
to
33ff2b2
Compare
ondrejmirtes
force-pushed
the
tagged-unions
branch
2 times, most recently
from
354abfa
to
ae2412e
Compare
ondrejmirtes
force-pushed
the
tagged-unions
branch
from
ae2412e
to
2096af5
Compare
ondrejmirtes
force-pushed
the
tagged-unions
branch
from
2096af5
to
a0abe91
Compare
|
I did not look into it before at all, but I'm amazed by how small the actual changes in this PR are. you did quite some precondition work already before though, right? |
|
Before the vacation I commited this #1548 which famously fixed something like 18 issues 😅 On vacation I could not stop thinking about this and during the afternoon break when kids were asleep I couldn't help myself but do something about problems the previous code uncovered. I've been fixing various related bugs, and the CI has been finally green last two days or so 😅 This dev cycle has been challenging to say the least. Some of the notable fixes are: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.