infer non-empty-string on substr() comparison with constant string #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo: verify this doesnt hit the same problem as #1275 |
clxmstaab
force-pushed
the
substr
branch
2 times, most recently
from
c2ec4dc
to
a24da7e
Compare
done. this one is good to go. |
infer non-empty-string on substr() comparison with constant string try reducing unnecessary work cs
This reverts commit 995712c.
ondrejmirtes
requested changes
May 17, 2022
|
Should this be re-targeted for 1.7.x? |
ondrejmirtes
approved these changes
May 21, 2022
|
Thanks :) Even if there isn't another 1.6.x release, I'm gonna merge it to 1.7.x right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs phpstan/phpstan#6792