try reducing unnecessary work

phpstan · Apr 28, 2022 · 3b176ac · 3b176ac
1 parent e55c37d
commit 3b176ac
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/src/Analyser/TypeSpecifier.php b/src/Analyser/TypeSpecifier.php
@@ -251,15 +251,18 @@ public function specifyTypesInCondition(
 					&& isset($exprNode->getArgs()[0])
 					&& $constantType instanceof ConstantStringType
 					&& $constantType->getValue() !== ''
-					&& $scope->getType($exprNode->getArgs()[0]->value)->isString()->yes()
 				) {
-					return $this->create(
-						$exprNode->getArgs()[0]->value,
-						TypeCombinator::intersect($scope->getType($exprNode->getArgs()[0]->value), new AccessoryNonEmptyStringType()),
-						$context,
-						false,
-						$scope
-					);
+					$argType = $scope->getType($exprNode->getArgs()[0]->value);
+
+					if ($argType->isString()->yes() && !$argType->isNonEmptyString()->yes()) {
+						return $this->create(
+							$exprNode->getArgs()[0]->value,
+							TypeCombinator::intersect($argType, new AccessoryNonEmptyStringType()),
+							$context,
+							false,
+							$scope,
+						);
+					}
 				}
 			}